Skip to content

[GLUTEN-10574] Add missing license headers#10872

Merged
PHILO-HE merged 5 commits intoapache:mainfrom
PHILO-HE:fix-license
Oct 13, 2025
Merged

[GLUTEN-10574] Add missing license headers#10872
PHILO-HE merged 5 commits intoapache:mainfrom
PHILO-HE:fix-license

Conversation

@PHILO-HE
Copy link
Member

@PHILO-HE PHILO-HE commented Oct 13, 2025

What changes are proposed in this pull request?

With Apache Rat, we found some missing license headers, which should be fixed before the release.
This patch will be backported to branch-1.5.

FYI.
java -jar apache-rat-0.16.1.jar -d /path/to/gluten/code -E excludes.txt, where excludes.txt contains

.*\.md
.*\.patch
.*\.txt
.*\.log
.*\.sql
.*\.out
.*\.proto
.*\.csv
.*\.parquet

How was this patch tested?

N/A

@github-actions
Copy link

#10574

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE
Copy link
Member Author

@weiting-chen, could you take a look?

@weiting-chen weiting-chen self-requested a review October 13, 2025 03:27
Copy link
Contributor

@weiting-chen weiting-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE merged commit 8749401 into apache:main Oct 13, 2025
60 checks passed
@PHILO-HE PHILO-HE deleted the fix-license branch October 13, 2025 09:46
@wForget
Copy link
Member

wForget commented Oct 13, 2025

Should we add apache-rat-plugin maven plugin for gltuen?

@PHILO-HE
Copy link
Member Author

Should we add apache-rat-plugin maven plugin for gltuen?

@wForget, thanks for your comment. We already have a CI job to check the license. It seems not all types of files are checked. We may just extend this job with Apache Rat check command used for better coverage. Maybe this centralized checking is better than introducing the maven plugin since the latter only covers maven project code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants